This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Add a startup filter which initializes the key ring before the server starts #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Jun 2, 2017
natemcmaster
force-pushed
the
namc/flop-flip
branch
from
f9e047f to
285b973
Compare
natemcmaster
force-pushed
the
namc/startup-filter
branch
from
b17acab to
cd799b8
Compare
natemcmaster
force-pushed
the
namc/startup-filter
branch
from
cd799b8 to
fe83e69
Compare
|
What release does this go into now? |
|
We merged to 'dev' which means this will go into the next release. We are currently calling this "2.0.0-preview3" |
|
So no chance of getting this into 1.x for folks still there? |
|
We can consider it. Let's track that discussion here #242. We occasionally back-port fixes to 1.x if we feel they are very important and won't break most users. |
|
Ok, thanks. One my my customers was on the original issue/thread here, and from their perspective data protection is in essence broken and unusable until this fix makes it into a release (as I'd imagine anyone else trying to use data protection, especially in azure). They aren't really in a position to move to 2.0 anytime soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #233 by running key ring initialization before the thread pool is consumed by processing requests.
Depends on #240