This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Make ILoggerFactory an optional service on any DI-injected services #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
force-pushed
the
namc/logging
branch
2 times, most recently
from
f89f199 to
12f3e3b
Compare
|
cc @rynowak FYI |
ajaybhargavb
approved these changes
Jun 13, 2017
after making sure the samples run as expected.|
|
||
| IDataProtectionProvider dataProtectionProvider = null; | ||
| dataProtectionProvider = new KeyRingBasedDataProtectionProvider(keyRingProvider, loggerFactory); | ||
| IDataProtectionProvider dataProtectionProvider = new KeyRingBasedDataProtectionProvider(keyRingProvider, loggerFactory); |
There was a problem hiding this comment.
Explicit typing required. Implicit typing would cause a compiler error due to the assignment that follows.
pakrym
approved these changes
Jun 13, 2017
natemcmaster
force-pushed
the
namc/logging
branch
from
02093c2 to
a39bcaf
Compare
natemcmaster
force-pushed
the
namc/logging
branch
from
a39bcaf to
5d1a523
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #243