This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Add KeyVault encryption to DataProtection #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
commented
Sep 1, 2017
|
|
||
| using (var symmetricAlgorithm = DefaultSymmetricAlgorithmFactory()) | ||
| { | ||
| var symmetricBlockSize = symmetricAlgorithm.BlockSize / 8; |
There was a problem hiding this comment.
@blowdart can please check that this is done correctly?
natemcmaster
reviewed
Sep 1, 2017
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration" Version="$(AspNetCoreVersion)" /> |
There was a problem hiding this comment.
Nit: remove Version="$(AspNetCoreVersion)"
natemcmaster
reviewed
Sep 1, 2017
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.AspNetCore.Testing" /> |
There was a problem hiding this comment.
Remove this. It's duplicated from Directory.Build.props
| mock.VerifyAll(); | ||
| Assert.NotNull(result); | ||
| Assert.NotNull(value); | ||
| Assert.Equal(typeof(AzureKeyVaultXmlDecryptor), result.DecryptorType); |
There was a problem hiding this comment.
Nit: Assert.IsType<AzureKeyVaultXmlDecryptor>(result.DecryptorType).
There was a problem hiding this comment.
This would be wrong, IsType checks type of an object, I'm checking Type instance equality.
| /// <returns>The value <paramref name="builder"/>.</returns> | ||
| public static IDataProtectionBuilder ProtectKeysWithAzureKeyVault(this IDataProtectionBuilder builder, string keyIdentifier, string clientId, string clientSecret) | ||
| { | ||
| if (clientId == null) |
There was a problem hiding this comment.
string.IsNullOrEmpty for string parameters
ajaybhargavb
reviewed
Sep 2, 2017
| /// Configures the data protection system to protect keys with specified key in Azure KeyVault. | ||
| /// </summary> | ||
| /// <param name="builder">The builder instance to modify.</param> | ||
| /// <param name="keyIdentifier">The Azure KeyVault key identifier used for key encryption.</param> |
There was a problem hiding this comment.
Nit: params misordered.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#92