This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Break read+write dependency in Stream copy op #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
force-pushed
the
read-write-dep
branch
from
abc7474 to
af7ff4d
Compare
|
|
||
| while (true) | ||
| private static async Task ArrayPoolCopyToAsyncInternal(Stream source, Stream destination, byte[] buffer0, byte[] buffer1, long? length, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Internal is redundant with private
|
After reading @stephentoub's comment on the corefx PR I'm not so sure this is a good idea. |
| if (bytesRemaining.HasValue) | ||
| while ((count = await lastReadTask) != 0) | ||
| { | ||
| if (count == 0) |
There was a problem hiding this comment.
Didn't you just check this on line 58?
|
It probably works but it's hard to follow. |
|
Comment @davidfowl is referring to dotnet/corefx#5954 (comment) |
|
Worth making changes, or close 👍 👎 ? |
|
meh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.