Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should assert.output("text") trim / normalize line endings? #13

Closed
epage opened this issue Jun 27, 2018 · 2 comments
Closed

Should assert.output("text") trim / normalize line endings? #13

epage opened this issue Jun 27, 2018 · 2 comments
Labels
breaking-change question Uncertainty is involved

Comments

@epage
Copy link
Contributor

epage commented Jun 27, 2018

Right now, str gets turned into a Utf8<Difference> set of predicates. Should we add trimming and line ending normalization to that?

assert_cli did trimming. This would allow people to work around it by directly passing in a predicate rather than relying on IntoOutputPredicate. Related: assert-rs/assert_cli#77
@epage epage added question Uncertainty is involved breaking-change labels Jun 27, 2018
@epage
Copy link
Contributor Author

epage commented Jun 27, 2018

See assert-rs/assert_cmd#19

@epage
Copy link
Contributor Author

epage commented Jul 30, 2018

Going to go ahead and say "no" due to principle of least surprise

@epage epage closed this as completed Jul 30, 2018
epage added a commit to epage/assert_fs that referenced this issue Apr 1, 2024
@epage
Merge pull request assert-rs#13 from epage/renovate/github-codeql-act…
739d2cf 
…ion-3.x

chore(deps): update github/codeql-action action to v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change question Uncertainty is involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage