feat(str): Specialized string predicates #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set` was an implementaton detail of only some of these predicates that test against collections of data. The collections can be unordered, ordered, or hashed. This also opens the door for more `iter` predicates. BREAKING CHANGE: `predicates::set` -> `predicates::iter`.
Reducing API footprint in prep for renaming. BREAKING CHANGE: `predicates::iter::contains_ord` -> `predicates::iter::contains(...).ord()`
The goal is to make the inention of the functions ore obvious especially as we add inverses of these. Fixes assert-rs#24 BREAKING CHANGE: Renamed functions and structs - `contains` -> `in_iter` - `contains_hashable` -> `in_hash` - `ContainsPredicate::ord` -> `ContainsPredicate::sort`
Including - starts_with - ends_with - contains Unfortunately, we can't take pattern, so we're limited to `Into<String>`. The only thing missing to complete assert-rs#25 is to add a `count` to `contains`. This would either be a number or a numeric predicate.
This sets a required count for number of matches.
It could be of value to make this accept a predicate. In that case, for
API convinience, we should probably have a `ToCountPredicate` that is
attached to both `Predicate<usize>` and `usize`. This would allow
things like `contains("Two").count(predicate::in_iter([3, 4])`.
Fixes assert-rs#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including
Unfortunately, we can't take pattern, so we're limited to
Into<String>.For
containsto make sense, I fixed #24.Fixes #25