Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side bar doesn't open in Internet Explorer #10

Closed
0ndifined opened this issue Sep 19, 2017 · 2 comments
Closed

Side bar doesn't open in Internet Explorer #10

0ndifined opened this issue Sep 19, 2017 · 2 comments
Assignees
@vickyokrm
Labels
Cmp: Rocket.Chat Core Priority: Critical Type: Bug

Comments

@0ndifined
Copy link

Using IE11 on Windows 7 BKU, the side bar doesn't show up in Assistify.

I already opened an issue on RocketChat github repo, because it seems that the current RocketChat version doesn't work on IE : RocketChat#8204
@mrsimpson mrsimpson mentioned this issue Sep 25, 2017
Closed
@vickyokrm vickyokrm self-assigned this Oct 5, 2017
@vickyokrm
Copy link

This issue is resolved now.

@mrsimpson
Copy link
Member

@vickyokrm if you fixed it, there should be a

  • commit, ideally with a commit-comment including the Github closing keywords
  • a PR towards the master (hotfix, like in this case) or develop (for features)
    Wafflebot will automatically close then

mrsimpson added a commit that referenced this issue Oct 6, 2017
@mrsimpson
fixes #10 - tested in chrome and IE on windows
1be4d95
mrsimpson added a commit that referenced this issue Oct 10, 2017
@mrsimpson
Merge remote-tracking branch 'origin/hotfix/#10-sidebar-IE-issue' int…
cd61929 
…o develop
vickyokrm added a commit that referenced this issue Oct 19, 2017
@vickyokrm
Merge branch 'develop' of https://github.com/assistify/Rocket.Chat in…
e5d81f2 
…to hotfix/#10-sidebar-IE-issue
vickyokrm added a commit that referenced this issue Oct 19, 2017
@vickyokrm
hotfix/#10: Fixes side nav scroll bar issue in IE
c2deb61
@vickyokrm vickyokrm mentioned this issue Oct 26, 2017
Merged
mrsimpson added a commit that referenced this issue Oct 26, 2017
@mrsimpson
Merge pull request #114 from assistify/hotfix/#10-sidebar-IE-issue
db1dc64 
quick hack for IE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vickyokrm vickyokrm

Labels
Cmp: Rocket.Chat Core Priority: Critical Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ruKurz @janrudolph @mrsimpson @0ndifined @vickyokrm