Allow renaming of requests #12
Conversation
|
@mrsimpson I commented your changes. But I'm not able to validate this PR in detail. From my point of view the code changes do not cause any error so I would suggest, merging the request, right now would be the best. |
|
@ruKurz to perform a local test. Create a request, open the channel setting tab bar (i)-Icon and rename it. |
| @@ -58,10 +58,10 @@ Template.AssistifyCreateRequest.events({ | |||
| console.log(err); | |||
| switch (err.error) { | |||
| case 'error-invalid-name': | |||
| toastr.error(TAPi18n.__('Invalid_room_name', name)); | |||
| toastr.error(TAPi18n.__('Invalid_room_name', `${ expertise }...`)); | |||
There was a problem hiding this comment.
seems like this is a real mistake, since 'expertise' has been there before.
Could it be that 'name' is a relict from a previous refactoring or this is relict by copy & paste?
| return; | ||
| case 'error-duplicate-channel-name': | ||
| toastr.error(TAPi18n.__('Duplicate_channel_name', name)); | ||
| toastr.error(TAPi18n.__('Request_already_exists')); |
| @@ -170,7 +170,7 @@ Template.channelSettings.onCreated(function() { | |||
| }, | |||
| save(value, room) { | |||
| let nameValidation; | |||
| if (!RocketChat.authz.hasAllPermission('edit-room', room._id) || (room.t !== 'c' && room.t !== 'p')) { | |||
| if (!RocketChat.authz.hasAllPermission('edit-room', room._id) || (room.t !== 'c' && room.t !== 'p' && room.t !== 'e' && room.t !== 'r')) { | |||
There was a problem hiding this comment.
what is the semantic of 'room.t' values.
Since I'm not that familiar with RC 'c', 'p', 'e', 'r' is not self explaining, even one could suggest.
Also I do not have any clue how the room type and the name vs. expertise thing belong together.
Fixes #11