Feature/#23 title first message to new request #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
- Added German translations - re-used an existing error message
- Dropdown overlapped by input field - In English, the width of the creation dialog was not 100%, thus input fields within too narrow
- Refactor error display to an own template - Show error if selected expertise on request creation is invalid (not chosen from the dropdown) - Fix positioning of "at" on members selection if invalid
mrsimpson
approved these changes
Nov 16, 2017
| @@ -2,6 +2,16 @@ | |||
| import {RocketChat} from 'meteor/rocketchat:lib'; | |||
| import {FlowRouter} from 'meteor/kadira:flow-router'; | |||
| import {ReactiveVar} from 'meteor/reactive-var'; | |||
| import toastr from 'toastr'; | |||
There was a problem hiding this comment.
@vickyokrm is that actually still required? I thought you had moved the validation error to the section beneath the input.
| } else { | ||
| t.checkRequestName(requestName); | ||
| } | ||
| // t.invalidTitle.set(!validateRequestName(requestName)); |
|
|
||
| if (!Meteor.userId()) { | ||
| throw new Meteor.Error('error-invalid-user', 'Invalid user', { | ||
| method: 'roomDisplayNameExists' |
There was a problem hiding this comment.
copy-paste => copy-paste-think-adapt ;)
mrsimpson
reviewed
Nov 16, 2017
| @@ -25,19 +25,24 @@ More_requests: Weitere Anfragen | |||
| New_expertise: Neues Thema | |||
| New_request_for_expertise: Neue Anfrage zum Thema | |||
| New_request: Neue Anfrage | |||
| New_request_created: Die neue Anfrage wurde erstellt | |||
…first-message-to-new-request # Conflicts: # packages/rocketchat-google-vision/.npm/package/npm-shrinkwrap.json
|
Travis has some exception after unit-tests passed => None of our business |
ruKurz
pushed a commit
that referenced
this pull request
Dec 7, 2017
* Fixed Issues 87, 88 * Feature/#23 title first message to new request (#149) * Request title and first message while creating new request * Make titles of inputs and placeholders more consistent * Fix display issues: - Dropdown overlapped by input field - In English, the width of the creation dialog was not 100%, thus input fields within too narrow * Minor corrections with respect to error handling: - Refactor error display to an own template - Show error if selected expertise on request creation is invalid (not chosen from the dropdown) - Fix positioning of "at" on members selection if invalid * Fixes #151 - Misspelled label "jetzt chaten" (#152) * Corrections to creation dialog (#154) * Corrections to creation dialog - Propagate first message properly (fixes #153) - Change "Name" to "Title" - get rid of flashing error message on auto-complete-confirmation with tab * Corrections to creation dialog - more robust error handling - prevent flashing of validation errors * Fix improper clearing of request title * Invalid Expertise field highlight * #156 Prefill request creation form (#157) * fixes #156 - Pass topic as URL param (URL encoded) as `topic` or `expertise` (same effect) - Title is focused if expertise is passed * Allow pre-filling of title and question as well. This way, fixes #20 : The consumer (e. g. the wiki page) can create a simple form an pass the content as parameter * - Use the copied current() instead of the internal value ``` FlowRouter.current ƒ () { // 248 // We can't trust outside, that's why we clone this … ``` - refactor query-selectors => reuse * use FlowRouter API properly * Setting based permissions - downport (#158) * Allow maintenance of per-setting permissions (cherry picked from commit eed869a) * Implicitly assign and revoke setting group permissions (cherry picked from commit 28b769b) * Improve Display of setting permissions (cherry picked from commit 8523456) * Add path to permission title (cherry picked from commit c87a30d) * Permission to access setting permissions (cherry picked from commit 48b1076) * Adapt wording (cherry picked from commit daccad8) * UI-adaptation: Allow users with permission 'manage-selected-permissions' to see and change the affected settings. However, this is not reactive: Once the permissions for a particular setting are changed, the user needs to log off and on again before it becomes effective in the UI. This is most probably a consequence of the CachedCollection. This collection needed to be changed on permission-change. In the backend however, the permissions become effective immediately. (cherry picked from commit 00e4bb5) * Don't adapt sorting on the client side (cherry picked from commit 9b71b62) * Fix: Apply changed setting permissions reactively (cherry picked from commit 293ad73) * Move setting-based permissions to own collection (cherry picked from commit 8f59f1c) * Unify collections for setting and other permissions again into one (cherry picked from commit 8d923c2) * Get rid of frontend exceptions on changing selected settings (cherry picked from commit a7fdc87) * - Sort permissions by group - Do not try to create permissions for hidden settings in higher-level-callbacks - Remove `setting-permissions` collection - fully integrated into `permissions` (cherry picked from commit f007231) * Harmonize wording in German (cherry picked from commit 5cf5df2) * German language informalized (#160) * German language informalized - Liebe Deutsche, wir kennen euch nun besser. Wir wollen ab jetzt “Du” zu einander sagen 😉 * Update de.i18n.json * Update de.i18n.json * Update de.i18n.json * Allow administration even if user has got only `edit-privileged-setting` but not `view-privileged-setting` * Revert "Fixed Issues 87, 88 (livechat on mobile devices)" (#164) * Create configuration expert role on startup (#159) * Allow maintenance of per-setting permissions (cherry picked from commit eed869a) * Implicitly assign and revoke setting group permissions (cherry picked from commit 28b769b) * Improve Display of setting permissions (cherry picked from commit 8523456) * Add path to permission title (cherry picked from commit c87a30d) * Permission to access setting permissions (cherry picked from commit 48b1076) * Adapt wording (cherry picked from commit daccad8) * UI-adaptation: Allow users with permission 'manage-selected-permissions' to see and change the affected settings. However, this is not reactive: Once the permissions for a particular setting are changed, the user needs to log off and on again before it becomes effective in the UI. This is most probably a consequence of the CachedCollection. This collection needed to be changed on permission-change. In the backend however, the permissions become effective immediately. (cherry picked from commit 00e4bb5) * Don't adapt sorting on the client side (cherry picked from commit 9b71b62) * Fix: Apply changed setting permissions reactively (cherry picked from commit 293ad73) * Move setting-based permissions to own collection (cherry picked from commit 8f59f1c) * Unify collections for setting and other permissions again into one (cherry picked from commit 8d923c2) * Get rid of frontend exceptions on changing selected settings (cherry picked from commit a7fdc87) * - Sort permissions by group - Do not try to create permissions for hidden settings in higher-level-callbacks - Remove `setting-permissions` collection - fully integrated into `permissions` (cherry picked from commit f007231) * Harmonize wording in German (cherry picked from commit 5cf5df2) * add configuration package * Add default role configuration on startup * set default system language to DE * Reduce capabilities of config expert and introduce minor admin * Parted the roles for configuration and managing the rest - Manager - well - manages the application, like a minor admin. Target is that this role is capable of doing everything which is necessary while *regularly* running the application - Config-expert is allowed to customize the application (affecting all users' experience) * Informal german language for our custom texts (#165) * German language informalized - Liebe Deutsche, wir kennen euch nun besser. Wir wollen ab jetzt “Du” zu einander sagen 😉 * German texts of custom enhancement informalized * Bump version to 0.5.0 * Update HISTORY.md
ruKurz
pushed a commit
that referenced
this pull request
Dec 13, 2017
* WIP: Proxy for Smarti stub
* WIP: Proxy for Smarti stub added to package
```
curl -X POST \
http://localhost:3000/api/v1/assistify/smarti/conversation/ \
-H 'content-type: application/json' \
-H 'x-auth-token: EKZ2_t7Wfqg5GML8bs44v3uS0d_b7f3rUd9IUYKNpvJ' \ //from login
-H 'x-user-id: S4Mew2PDtEPr3Ejne' \ //from login
-d '{
"thisIsMy":"JSON-Body"
}'
```
* use injected logger for logging in API
* Fixes #151 - Misspelled label "jetzt chaten"
* Using the configured access token as HTTP header
* Using the RC proxy for Smarti
* Revert "Feature/#23 title first message to new request (#149)"
This reverts commit 484b04c.
* Revert "Fixes #151 - Misspelled label "jetzt chaten""
This reverts commit 0c9ac4f.
* Fixing lint errors.
* Fixing non authorized access.
* fixed issue with wrong knowledge provider indexes
* improved tailing slashes for URLs
* - add authorization checks before routing the API calls
- roll back injected logger, since it is not defined
* removed unused localization keys
* Reducing code for adding a tailing slash to the Smarti URL.
* consolidate constants naming
* - Use RateLimiter for Smarti requests
- Use propagation function for 'onMessage' and 'onClose'
- Make Smarti the default knowledge provider
- Reordered Smarti backend settings
- Added descriptions for Smarti backend settings
- Also reload the settings, when reloading the Smarti widget
- Refactored file names
* Using rate limiter in each proxy method and limit the propagateToSmarti function instead of HTTP.call
* - merged proxy and adapter into only one file
- only use DDP for Smarti Widget / Rocket.Chat messages (getConversation, getSmartiQueryBuilderResult)
- added proxy endpoint for Smarti conversation search
- added several comments
* Migrate settings
* Extract Smarti loader
* additional migrations
* Do not migrate old settings with other defaults
* separated responsibilities
* Simplify adapter, proxy, router, widgetBackend
* Minor fixes to get it work with Smarti.
* Fix Webhook-token not being transmitted
* revert unintentional changes to other files after branching off the wron state.
Copied all changes from `develop` which were not included in `assistify:ai`-package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes new feature #23 .
Solution overview: This feature allows to add a custom title while creating a new request as well as add a first/opening message from the request creation screen. Also, Both the title and message are optional fields which can be left blank. Therefore, the new request creation shall work as usual as it was in the past without message and title.