Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive refactoring, preparation of Rocket.Chat 0.59 #97

Closed
wants to merge 1,086 commits into from

Conversation

mrsimpson
Copy link
Member

Purpose

This PR contains the basis of Assistify Rocket.Chat the way it should have been from the beginning: Loose coupling towards RC, less legacy artifacts, better quality (though still far from perfect).
In order to do that, RC needed to be updated to the most recent version.

Diff towards develop

Sinve the changelist is huge, the following list describes what's been done in order to achive the current state

Call to action

Due to the massive changelist, I ask all fellow developers to

  • check out this branch
  • perform manual testing (writing automated tests is of course more than appreciated ;)
  • Have a look at the folder and file structure, check dependencies - it should be verbose to anybody doing that what the purpose and general functionality is
  • comment on the PR by adding a review

@janrudolph I'll publish this release-candiadate to our team-server soon and ask you for functional testing.

karlprieb and others added 30 commits September 21, 2017 16:16
Fix `leave and hide` click, color and position
…MergeCaseInsensitveEmail

[FIX] Case insensitive SAML email check
the how it all started link was broken.
the blog changed its domain and blog post url
[FIX] clipboard and permalink on new popover
[NEW] Enable read only channel creation
[FIX] sidenav colors, hide and leave, create channel on safari
…MergeCaseInsensitveEmail

[FIX] Case insensitive SAML email check
[FIX] Api groups.files is always returning empty
Fix `leave and hide` click, color and position
rodrigok and others added 22 commits October 17, 2017 17:51
…oute-reload

[FIX] Uncessary route reload break some routes
…-password

Fix: Change password not working in new UI
Fix high CPU load when sending messages on large rooms (regression)
…s/rocketchat-theme/client/imports/general/variables.css
@mrsimpson mrsimpson requested a review from janrudolph October 18, 2017 21:33
@ghost ghost assigned mrsimpson Oct 18, 2017
@ghost ghost added the progress:working label Oct 18, 2017
@mrsimpson mrsimpson mentioned this pull request Oct 18, 2017
@mrsimpson
Copy link
Member Author

as 0.59.0 is out now, created a new PR #98 as replacement for this one

@mrsimpson mrsimpson closed this Oct 19, 2017
@mrsimpson mrsimpson deleted the release/0.59.0_rc15-0.4.0 branch October 19, 2017 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.