Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support :session keyword (fix #1) #78

Closed
wants to merge 4 commits into from
Closed

support :session keyword (fix #1) #78

wants to merge 4 commits into from

Conversation

FelipeLema
Copy link

@FelipeLema FelipeLema commented Aug 18, 2021

using session-async allows for code evaluation to preserve a global state (such as :session) between calls

  • change async with session-async
  • add tests for :session

fixes #1

- add `session-async` as dependency
- maintain a global session for ob-async
- use `session-async-start` instead of `async-start`
Dunno why the second block would print \n at the end. Added a trim
because of that.
@FelipeLema FelipeLema marked this pull request as ready for review August 20, 2021 19:39
@FelipeLema
Copy link
Author

another benefit of this is that tramp overhead (which can get to several seconds) is paid once on first execution, rather than once-per-execution

`package-initialize` can be _real_ expensive
@astahlman
Copy link
Owner

@FelipeLema this is exciting to see! Glanced at this briefly but I need to spend some time understanding session-async. I'll try to give this a proper review in the next few days

@daraul
Copy link

daraul commented Aug 4, 2022

How come this was closed?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ob-async should support :session header-arg
3 participants