Build system refactor to prepare for parallel Python version building #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm about to enable support for parallel CPython builds. This function was currently not safe if called in parallel. This was causing setuptools / pip downloads to race writing to the same file and failing builds.
This is less ergonomic (oh Make). But it will make it easier to build multiple Python versions at the same time in a future commit.
Previously we generated the same Makefile for every Python version. We can simplify things by only writing 1 Makefile per target configuration.
This refactor allows targets for each major Python version to be defined simultaneously. This opens the door to a single `make` invocation building multiple versions in parallel.
|
Thanks! Will review on Monday. |
zanieb
approved these changes
Dec 16, 2024
|
Yeah, make is a "fun" language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits (read the individual commit messages for more details) prepares the cpython-unix build system for building multiple Python X.Y versions in parallel. We don't yet actually implement the frontend support for parallel builds so the scope of the PR is more manageable and limited to (supposedly) backwards compatible behavior.