Fix single-cell formatting #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
astral-sh/ruff#12864 changed ruff to respect the language specified in
cell.metadatawhen determining Python cells. To do so, the PR added the newcell.metadatafield and made it required as specified in the specification.#485 patched ruff-lsp to send an empty dict for
cell.metadatabut we, unfortunately, missed updating the JSON for a single cell document that is used by the formatter. This PR fixes this.Fixes astral-sh/ruff-vscode#617
Test Plan
I tested that formatting notebooks is working as expected.