Skip to content

Commit

Permalink
Update Node version in release workflow (#633)
Browse files Browse the repository at this point in the history
## Summary

This PR updates the minimum Node version to 22 and is a follow-up from
#631. The dependencies that
we use to publish the build artifacts bumped the minimum version of Node
to 20. I've bumped it to 22 as that's the minimum active LTS version
right now.

Along with the node version bump, this PR also updates the said
dependencies (`ovsx` and `vsce`) to the latest version which requires a
minimum node version of 20.

## Test Plan

When I perform the next release :)
  • Loading branch information
dhruvmanila authored Oct 22, 2024
1 parent 539e074 commit 4687dff
Show file tree
Hide file tree
Showing 3 changed files with 260 additions and 109 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ jobs:

# Install Node.
- name: Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22

# Install Node dependencies.
- run: npm ci
Expand Down Expand Up @@ -172,9 +172,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Install Nodejs
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22

- name: Checkout repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -237,9 +237,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Install Nodejs
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22

- name: Checkout repository
uses: actions/checkout@v3
Expand Down
Loading

0 comments on commit 4687dff

Please sign in to comment.