Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode status bar display is weird in the latest (2024.44.0) #605

Closed
ryokaji opened this issue Sep 7, 2024 · 1 comment · Fixed by #608
Closed

VSCode status bar display is weird in the latest (2024.44.0) #605

ryokaji opened this issue Sep 7, 2024 · 1 comment · Fixed by #608
Assignees
Labels
bug Something isn't working

Comments

@ryokaji
Copy link

ryokaji commented Sep 7, 2024

What happens

When 2024.44.0 is installed, the Status bar display in the default (v0.6.4) looks like hunging up as follows.
image

This does not occur if Ruff v0.5.7 is explicitly specified in the settings.
image

*note: This issue is not reporting a bug, the extension looks working fine.

System Info

VSCode version: 1.91.1
Python version: 3.11.2
Host OS:

  • Microsoft Windows 10 Home 22H2 19045.4780
  • macOS Sonoma 14.5

Project structure

The following stuff is minimum configuration to reproduce the issue.

Settings

{
    // Configuration to explicitly specify v0.5.7
    // Assuming that a venv has been created in ~/poc.
    "ruff.path": [
        "/home/node/poc/bin/ruff"
    ]
}

Others

files:

.
├── hello.py
└── .vscode
    └── settings.json

hello.py

print("hello")
@MichaReiser MichaReiser added the bug Something isn't working label Sep 8, 2024
@MichaReiser
Copy link
Member

Thanks. I can reproduce this by just opening a python project.

@MichaReiser MichaReiser self-assigned this Sep 8, 2024
dhruvmanila added a commit that referenced this issue Sep 9, 2024
## Summary

Ensures that the extension calls `updateStatus` with `busy=false` when
the server startup is complete.

This is now necessary after
#600 correctly added an
`updateStatus` call with `busy=true` before the server starts.

Fixes #605

## Test Plan

I ran the extension and verified that the busy indicator no longer spins
forever.

---------

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants