Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with example for using ruff.args in settings.json #283

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

simkimsia
Copy link
Contributor

Based on a suggestion in astral-sh/ruff#7474 (reply in thread), I'm making this change to make it easier for newbies like me to customize ruff using settings.json.

Specifically using ruff.args in settings.json

Summary

As a newbie i didn't know i can use ruff.args. see astral-sh/ruff#7474 (reply in thread). So I added an example in the vscode extension readme.

Test Plan

This is README, so no tests needed

Based on a suggestion in astral-sh/ruff#7474 (reply in thread), I'm making this change to make it easier for newbies like me to customize ruff using settings.json
@fa-ribeiro
Copy link

Note that VS Code Insiders (Version: 1.84.0-insider) is marking ruff.args as deprecated and advising to use ruff.lint.args instead.

@simkimsia
Copy link
Contributor Author

I have noticed this just yesterday on regular vs code

Will change this when I reach laptop in 1 hr

simkimsia and others added 3 commits October 22, 2023 13:23
Change the example of using `ruff.args` to `ruff.lint.args` as vscode has now deprecated `ruff.args`

Signed-off-by: KimSia, Sim <245021+simkimsia@users.noreply.github.com>
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for the delay.

@charliermarsh charliermarsh merged commit 139d1d8 into astral-sh:main Jan 5, 2024
6 checks passed
@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants