Build ARM Mac extension on M1 runners #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/bump
branch
4 times, most recently
from
af5eb6f to
1edc3cb
Compare
charliermarsh
changed the title
zanieb
approved these changes
Dec 14, 2023
charliermarsh
force-pushed
the
charlie/bump
branch
from
1edc3cb to
51c7cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point between 2023.50.0 and 2023.52.0, something changed in the GitHub Actions runners such that both the x86 and ARM mac builds starting using Ruff's x86 wheel. This breaks the extension when using the bundled Ruff on an M-series MacBook. (In 2023.50.0 and earlier, it turns out we were using the universal wheel for the x86 build too, which is okay, though not identical to what pip does on x86 machines.)
This PR forces the build pipeline to use the M-series MacBooks for macOS builds, and then sets the arch explicitly. As such, we now use universal for the ARM extension and x86 for the x86 extension.