Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude scripts directory from extension bundle #373

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

kieran-ryan
Copy link
Contributor

@kieran-ryan kieran-ryan commented Dec 23, 2023

Summary

Excludes scripts/ (added in #251) from the extension bundle as it is not required.

Current bundle:

extension/
├─ bundled/
├─ dist/
├─ scripts/
│  ├─ bump_extension_version.sh
│  ├─ bump_lsp_version.sh
│  ├─ bump_ruff_version.sh
├─ CHANGELOG.md
├─ icon.png
├─ LICENSE.txt
├─ package.json
├─ pyproject.toml
├─ README.md

Test Plan

Built the package, installed it manually through ruff.vsix and launched the extension to verify continued functionality.

python -m pip install -t ./bundled/libs --implementation py --no-deps --upgrade -r ./requirements.txt
npm install
npm run vsce-package

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems reasonable!

@charliermarsh charliermarsh merged commit 877392f into astral-sh:main Dec 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants