fix: usage of deprecated Node.js 16 actions
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummaryThis pull request updates Test PlanCI Without this change
With this change
|
hamirmahal
commented
Apr 12, 2024
.github/workflows/ci.yaml
Outdated
Comment on lines
24
to
26
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} |
There was a problem hiding this comment.
It looks like we can exclude this step because we Install dependencies with just install anyway in the next step.
There was a problem hiding this comment.
I think this installs the Python version, whereas just install installs the Python dependencies.
There was a problem hiding this comment.
Ah, my mistake; I updated the pull request.
hamirmahal
force-pushed
the
fix/usage-of-deprecated-nodejs-16-actions
branch
from
ca59690
to
ec2d39f
Compare
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #446.