Separate server start / stop logic #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
approved these changes
Jul 24, 2024
dhruvmanila
commented
Jul 24, 2024
Comment on lines
273
to
276
| export async function deactivate(): Promise<void> { | ||
| if (lsClient) { | ||
| await lsClient.stop(); | ||
| await stopServer(lsClient); | ||
| } | ||
| } |
There was a problem hiding this comment.
Also, this is a bugfix because otherwise the listeners wouldn't be disposed.
dhruvmanila
force-pushed
the
dhruv/finally
branch
from
1246edc to
382286f
Compare
dhruvmanila
added a commit
that referenced
this pull request
Jul 24, 2024
## Summary This PR is a refactor to use `try .. finally` in the logic which starts the server to always reset the debounce state variable (`restartInProgress`). This is to ensure that it's always reset even in case of a failure. ## Test Plan Refer to the test plan in #559.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #558
This PR separates the server start and stop logic.
This is required because the extension could skip starting the server in the following cases:
So, if the extension was already running and the settings were updated to hit any one of the above cases, the server would still be running (not ideal).
Test Plan
Here, the diagnostics should disappear because the server stopped first before checking for the interpreter.
For (1),
I'd need to uninstall all Python versions for me to reproduce this so I'm skipping this scenario assuming that (2) and (3) is sufficient.
For (2),
Screen.Recording.2024-07-24.at.20.40.07.mov
For (3),
Screen.Recording.2024-07-24.at.20.38.43.mov