Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The logFile language server setting should support shell expansion #11911

Closed
snowsignal opened this issue Jun 18, 2024 · 0 comments · Fixed by #11945
Closed

The logFile language server setting should support shell expansion #11911

snowsignal opened this issue Jun 18, 2024 · 0 comments · Fixed by #11945
Assignees
@snowsignal
Labels
server Related to the LSP server
Milestone
Ruff Server: Stable

Comments

@snowsignal
Copy link
Contributor

Follow-up to this review comment: #11883 (comment)

We should support shell expansion for logFile, which will enable users to use tildes and environment variables in the log file path, similar to how we support this with the configuration setting.
@snowsignal snowsignal added the server Related to the LSP server label Jun 18, 2024
@snowsignal snowsignal added this to the Ruff Server: Stable milestone Jun 18, 2024
@snowsignal snowsignal self-assigned this Jun 18, 2024
@snowsignal snowsignal mentioned this issue Jun 20, 2024
Merged
snowsignal added a commit that referenced this issue Jun 20, 2024
@snowsignal
ruff server: Support the usage of tildes and environment variables …
c8ff89c 
…in `logFile` (#11945)

## Summary

Fixes #11911.

`shellexpand` is now used on `logFile` to expand the file path, allowing
the usage of `~` and environment variables.

## Test Plan

1. Set `logFile` in either Neovim or Helix to a file path that needs
expansion, like `~/.config/helix/ruff_logs.txt`.
2. Ensure that `RUFF_TRACE` is set to `messages` or `verbose`
3. Open a Python file in Neovim/Helix
4. Confirm that a file at the path specified was created, with the
expected logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snowsignal snowsignal

Labels
server Related to the LSP server
Projects
None yet
Milestone
Ruff Server: Stable
Development

Successfully merging a pull request may close this issue.

ruff server: Support the usage of tildes and environment variables in logFile astral-sh/ruff
1 participant
@snowsignal