Implement tryceratops

[sbrugman]

• TC002: Create your own exception
• TC003: Avoid specifying long messages outside the exception class
• TC004: Prefer TypeError exception for invalid type
• TC100: Check to continue
• TC101: Too many try blocks
• TC200: Use raise Exception from
• TC201: Simply use raise
• TC202: Don't ignore a broad exception without even logging
• TC300: Consider adding an else block
• TC301: Avoid direct raises in try body
• TC400: Use logging .exception instead of .error
• TC401: Do not log the exception object

[alonme]

Taking TC201

[sbrugman]

For tracking: I'm working on TC004

[karpa4o4]

@charliermarsh, i would like to do TC200.

[charliermarsh]

Awesome -- thanks all! Will review as they come in :)

[karpa4o4]

I'll take TC301 next.

[Flowake]

I'd like to implement TC400, which would be my first rule so it might take a few days. Would that be fast enough ?

[charliermarsh]

@Flowake - Sure! Take your time. Feel free to open a draft PR and ask questions there if you run into any.

[karpa4o4]

I'll take TC002 next.

[bigluck]

Ciao, I'm testing the new implementation, but I'm getting this error: TRY300 Consider else block

Isn't it a false positive?
Thanks so much

[charliermarsh]

Hmm, comparing to the original plugin, I think what's incorrect is the highlighted region. It seems to want you to do this (omitting some intermediary lines since I had to copy from the screenshot :)):

try:
    assert isinstance(value, list) is False
except Exception as exc:
    msg = ""
    raise EnsureStrException(msg)
else:
    return str(value)

[charliermarsh]

(Fixed in #2228.)

[bigluck]

Superb, thanks!

[jacopotagliabue]

@charliermarsh me and luca should buy you lunch in BKL - ping me on linkedin or whatever and I'm happy to buy you lunch. Thanks for all the great work!

[colin99d]

Taking TC401 and TC202