Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add next to FBT003 exclusions #6711

Closed
Garrett-R opened this issue Aug 21, 2023 · 1 comment · Fixed by #6729
Closed

Add next to FBT003 exclusions #6711

Garrett-R opened this issue Aug 21, 2023 · 1 comment · Fixed by #6729
Assignees
@charliermarsh
Labels
accepted Ready for implementation bug Something isn't working

Comments

@Garrett-R
Copy link

Garrett-R commented Aug 21, 2023 •
edited
Loading

Following on from this discussion and this PR, it might be good to add the Python builtin next to the exclusions list for FBT003.

Consider this code:

next(my_generator, False)

The rule is upset about False here, but there is no keyword arg you can use. Trying to use default=False yields: TypeError: next() takes no keyword arguments.
@charliermarsh charliermarsh added accepted Ready for implementation bug Something isn't working labels Aug 21, 2023
@charliermarsh charliermarsh self-assigned this Aug 21, 2023
@charliermarsh charliermarsh mentioned this issue Aug 21, 2023
Merged
charliermarsh added a commit that referenced this issue Aug 21, 2023
@charliermarsh
Allow next in FBT exclusions (#6729)
83f6889 
Closes #6711.
@Garrett-R
Copy link
Author

Heyooo! 🚀

@9128305 9128305 mentioned this issue Mar 12, 2024
Closed
@redb0 redb0 mentioned this issue Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
accepted Ready for implementation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow next in FBT exclusions astral-sh/ruff
2 participants
@charliermarsh @Garrett-R