Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Show source context by default in ruff check #7349

Closed
zanieb opened this issue Sep 13, 2023 · 4 comments · Fixed by #9687 or #9814
Closed

CLI: Show source context by default in ruff check #7349

zanieb opened this issue Sep 13, 2023 · 4 comments · Fixed by #9687 or #9814
Assignees
@MichaReiser
Labels
cli Related to the command-line interface
Milestone
v0.5.0

Comments

@zanieb
Copy link
Member

zanieb commented Sep 13, 2023 •
edited
Loading

The --show-source flag can be used to show source information alongside violations during ruff check. This should be the default behavior.

--no-show-source can be used to return to the previous output. In the future, this option will be removed; see #7350.
@zanieb zanieb added the cli Related to the command-line interface label Sep 13, 2023
@MichaReiser

This comment was marked as resolved.

Sign in to view
This was referenced Sep 13, 2023
Closed
Open
Open
@snowsignal snowsignal mentioned this issue Jan 29, 2024
Merged
@zanieb zanieb added this to the v0.3.0 milestone Jan 30, 2024
@MichaReiser MichaReiser modified the milestones: v0.3.0, v0.4 Feb 14, 2024
@charliermarsh
Copy link
Member

This is already the case in preview, right?

@zanieb
Copy link
Member Author

zanieb commented Feb 25, 2024

Yeah I believe this was completed in #9687

Should we leave the issue open to track making it the non-preview default?

@dhruvmanila dhruvmanila mentioned this issue Apr 15, 2024
Merged
@dhruvmanila dhruvmanila modified the milestones: v0.4.0, v0.5.0 Apr 18, 2024
@MichaReiser MichaReiser mentioned this issue Jun 24, 2024
Merged
@MichaReiser MichaReiser self-assigned this Jun 25, 2024
MichaReiser added a commit that referenced this issue Jun 26, 2024
@MichaReiser
Remove output format text and use format full by default (#12010)
0501afd 
Resolves #7349
@MichaReiser MichaReiser modified the milestones: v0.5.0, v0.6 Jun 26, 2024
@T-256
Copy link
Contributor

T-256 commented Jun 26, 2024

IIUC --output-fomat=full as default is stabilized in v0.5, why keeping this issue for v0.6 milestone?

@MichaReiser MichaReiser mentioned this issue Jun 26, 2024
Merged
MichaReiser added a commit that referenced this issue Jun 27, 2024
@MichaReiser
Remove output format text and use format full by default (#12010)
78ffe79 
Resolves #7349
MichaReiser added a commit that referenced this issue Jun 27, 2024
@MichaReiser
Remove output format text and use format full by default (#12010)
41203ea 
Resolves #7349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaReiser MichaReiser

Labels
cli Related to the command-line interface
Projects
None yet
Milestone
v0.5.0
5 participants
@MichaReiser @charliermarsh @zanieb @dhruvmanila @T-256