Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecosystem #10064

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix ecosystem #10064

merged 1 commit into from
Feb 20, 2024

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Feb 20, 2024

Summary

I don't understand why our ecosystem check suddenly started failing but the reason is that the dawidd6/action-download-artifact action now uses the release workflow instead of the CI workflow. I've honestly been too lazy to debug what happened and hardcoding the workflow works as expected.

Test Plan

The ecosystem checks on this branch are passing

@MichaReiser MichaReiser force-pushed the ecosystem-check branch 2 times, most recently from 502acd2 to 3ea390e Compare February 20, 2024 15:08
@MichaReiser MichaReiser added the ci Related to internal CI tooling label Feb 20, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seems reasonable

@MichaReiser MichaReiser marked this pull request as ready for review February 20, 2024 15:54
@MichaReiser MichaReiser merged commit ee4efdb into main Feb 20, 2024
17 checks passed
@MichaReiser MichaReiser deleted the ecosystem-check branch February 20, 2024 15:54
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants