Reduce size of Stmt from 144 to 120 bytes #11051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I happened to notice that we box
TypeParams
onStmtClassDef
but not onStmtFunctionDef
and wondered why, sinceStmtFunctionDef
is bigger and sets the size ofStmt
.@charliermarsh found that at the time we started boxing type params on classes, classes were the largest statement type (see #6275), but that's no longer true.
So boxing type-params also on functions reduces the overall size of
Stmt
.Test Plan
The
<=
size tests are a bit irritating (since their failure doesn't tell you the actual size), but I manually confirmed that the size is actually 120 now.