-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated extend-ignore
and extend-unfixable
options
#12007
Remove deprecated extend-ignore
and extend-unfixable
options
#12007
Conversation
8493d77
to
b156c7b
Compare
ignore: self | ||
.ignore | ||
.iter() | ||
.cloned() | ||
.chain(self.extend_ignore.iter().cloned()) | ||
.flatten() | ||
.collect(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit unfortunate. We never added deprecation warnings to the CLI. I'm inclined to keep and hide the CLI options for now but add a deprecation warning instead.
It also seems that python-lsp-ruff is using the CLI option :(
b156c7b
to
f8c6f56
Compare
Yeah, I would vote not to remove these. They were never properly deprecated. Honestly, I would vote not to deprecate them, even (or to un-deprecate them). I think it would be surprising to users that they don't exist. If they didn't exist, I would consider adding them, even though they're undifferentiated from |
|
I'll create an issue to follow up on this. Closing as per @charliermarsh's comment. Follow up in #12014 |
Summary
This PR removes the deprecated
lint.extend-ignore
andlint.extend-unfixable
options. The options were deprecated in #2312 (0.0.238)Part of #7650
Test Plan
Running ruff with a configuration containing
extend-ignore
orextend-unfixable
now failsChanging the option to
ignore
"ignores" the rule as expected.