Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruff] Rename RUF007 to zip-instead-of-pairwise #12399

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Jul 18, 2024

Summary

Renames the rule RUF007 from pairwise-over-zipped to zip-instead-of-pairwise. This closes #12397.

Specifically, in this PR:

  • The file containing the rule was renamed
  • The struct was renamed
  • The function implementing the rule was renamed

Testing

  • cargo test
  • Docs re-built locally and verified that new rule name is displayed. (Screenshots below).
New rule name in rule summary New rule name in rule details

@charliermarsh charliermarsh changed the title Rename ruf007 [ruff] Rename RUF007 to zip-instead-of-pairwise Jul 18, 2024
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Jul 18, 2024
@charliermarsh
Copy link
Member

Thanks!

@charliermarsh charliermarsh merged commit d617470 into astral-sh:main Jul 18, 2024
19 checks passed
@dylwil3 dylwil3 deleted the rename-ruf007 branch July 18, 2024 23:27
@hauntsaninja
Copy link
Contributor

Maybe my English is off, but shouldn't this be pairwise-instead-of-zip ?

@charliermarsh
Copy link
Member

I think this is correct, because the convention is such that "allow zip-instead-of-pairwise" should make sense (given that we're recommending pairwise to the user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUF007 violates naming convention
3 participants