Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove output-format=text setting #12836

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Aug 12, 2024

Summary

Using output-format=text is a hard error since Ruff 0.5 (#12010).

This PR removes the custom error message.

Test Plan

ruff failed
  Cause: Failed to parse /home/micha/astral/test/pyproject.toml
  Cause: TOML parse error at line 4, column 15
  |
4 | output-format="text"
  |               ^^^^^^
unknown variant `text`, expected one of `concise`, `full`, `json`, `json-lines`, `junit`, `grouped`, `github`, `gitlab`, `pylint`, `rdjson`, `azure`, `sarif`

@MichaReiser MichaReiser added the configuration Related to settings and configuration label Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thoughts as #12833 (review) -- I'd probably keep the nice error message for another minor version personally, but don't have a strong opinion

@MichaReiser MichaReiser added this to the v0.7 milestone Aug 12, 2024
@MichaReiser MichaReiser changed the base branch from ruff-0.6 to main August 12, 2024 14:00
@AlexWaygood AlexWaygood changed the base branch from main to ruff-0.7 October 8, 2024 11:34
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaReiser MichaReiser merged commit 2fffb4f into ruff-0.7 Oct 8, 2024
20 checks passed
@MichaReiser MichaReiser deleted the remove-output-format-text branch October 8, 2024 11:46
@AlexWaygood AlexWaygood added the internal An internal refactor or improvement label Oct 8, 2024
AlexWaygood pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Related to settings and configuration internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants