[pep8-naming] Don't flag from imports following conventional import names (N817)
#12946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt names (`N817`)
AlexWaygood
approved these changes
Aug 17, 2024
crates/ruff_linter/src/rules/pep8_naming/rules/camelcase_imported_as_acronym.rs
Show resolved
Hide resolved
crates/ruff_linter/src/rules/pep8_naming/rules/camelcase_imported_as_acronym.rs
Show resolved
Hide resolved
|
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Could you please confirm that this fix is working also for jupyter (.ipynb) files? |
|
@darosio I think this should work for Jupyter notebooks as well. Is there an issue that you're facing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12940
#12922 changes
N817to not flag imports that follow an import convention.I missed to handle
from .. importimports as part of this PR. This PR implements the same logic forfrom .. importimports.Test Plan
Added test