Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Understand Annotated #14950

Merged
merged 24 commits into from
Dec 13, 2024
Merged

[red-knot] Understand Annotated #14950

merged 24 commits into from
Dec 13, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14922.

Test Plan

Markdown tests.

@InSyncWithFoo InSyncWithFoo force-pushed the rk-annotated branch 6 times, most recently from 8f32540 to df74504 Compare December 13, 2024 03:18
@InSyncWithFoo
Copy link
Contributor Author

Alright, I'm out of ideas for now. What am I missing?

carljm
carljm reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Sorry about the bad experience, our expression coverage and the way it manifests in hard-to-debug errors is a known pain point we want to improve.

crates/red_knot_python_semantic/resources/mdtest/annotations/annotated.md Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/annotated.md Show resolved Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/annotated.md Show resolved Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/annotated.md Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

InSyncWithFoo and others added 4 commits December 13, 2024 13:33
@InSyncWithFoo
Fix again
0ed607f
@InSyncWithFoo @AlexWaygood
Update crates/red_knot_python_semantic/src/types/diagnostic.rs
fbe0a4e 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@InSyncWithFoo @AlexWaygood
Apply suggestions from code review
7568b31 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@InSyncWithFoo
Rebase
f34c372
AlexWaygood
AlexWaygood approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexWaygood AlexWaygood requested a review from carljm December 13, 2024 15:06
carljm
carljm approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

crates/red_knot_python_semantic/src/types.rs Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/diagnostic.rs Outdated Show resolved Hide resolved
InSyncWithFoo and others added 4 commits December 13, 2024 16:26
carljm
carljm approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

crates/red_knot_python_semantic/src/types/diagnostic.rs Show resolved Hide resolved
@carljm carljm merged commit aa1938f into astral-sh:main Dec 13, 2024
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-annotated branch December 13, 2024 17:50
@InSyncWithFoo InSyncWithFoo mentioned this pull request Dec 13, 2024
Merged
carljm pushed a commit that referenced this pull request Dec 13, 2024
@InSyncWithFoo
[red-knot] Alphabetize rules (#14960)
9798556 
## Summary

Follow-up from #14950.

## Test Plan

Purely stylistic change. Shouldn't affect any functionalities.
dcreager added a commit that referenced this pull request Dec 13, 2024
@dcreager
Merge branch 'main' into dcreager/module-resolution
7ae011c 
* main:
  [red-knot] Use `type[Unknown]` rather than `Unknown` as the fallback metaclass for invalid classes (#14961)
  [red-knot] Make `is_subtype_of` exhaustive (#14924)
  [red-knot] Alphabetize rules (#14960)
  [red-knot] Understand `Annotated` (#14950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm carljm approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[red-knot] Understand Annotated
4 participants
@InSyncWithFoo @carljm @AlexWaygood @MichaReiser