[red-knot] Cleanup various todo_type!() messages
#15063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
requested review from
carljm,
MichaReiser and
sharkdp
as code owners
AlexWaygood
force-pushed
the
alex/redknot-todo-messages
branch
from
1e7b7ee to
c02bf09
Compare
MichaReiser
reviewed
Dec 19, 2024
Co-authored-by: Micha Reiser <micha@reiser.io>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No functional change here -- this just improves our
todo_type!()messages in several places. At some locations, this involves propagating an existing TODO message instead of overwriting it with a worse one (or overwriting it with no TODO message at all)Test Plan
cargo test -p red_knot_python_semantic