Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake-pyi PYI033 "Do not use type comments in stubs" #3302

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Add flake-pyi PYI033 "Do not use type comments in stubs" #3302

merged 3 commits into from
Mar 3, 2023

Commits on Mar 2, 2023

  1. Add flake-pyi PYI033 "Do not use type comments in stubs" 

    I think this is also a case where people like want this for .py files, too, at least on 3.7+ (https://docs.python.org/3/whatsnew/3.7.html#pep-563-postponed-evaluation-of-annotations)

On that note, does none of the tools upgrade all type comments to type annotations automatically? I looked in pyupgrade and googled but couldn't find anything
    @konstin
    konstin committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5e3481c View commit details
    Browse the repository at this point in the history

  2. Use flake8-pyi tests and ignore # type: ignore

    @konstin
    konstin committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e44968c View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Improve TypeCommentInStub doc string 

    Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
    @konstin @charliermarsh
    konstin and charliermarsh committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    03665b2 View commit details
    Browse the repository at this point in the history