Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename remaining use-* rules #3661

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Rename remaining use-* rules #3661

merged 1 commit into from
Mar 22, 2023

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Mar 22, 2023

Closes: #2902.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.01     13.5±0.05ms     3.0 MB/sec    1.00     13.5±0.03ms     3.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.01ms     4.7 MB/sec    1.00      3.5±0.01ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00    486.6±5.78µs     6.1 MB/sec    1.00    484.6±4.43µs     6.1 MB/sec
linter/all-rules/pydantic/types.py         1.01      6.0±0.03ms     4.3 MB/sec    1.00      5.9±0.01ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.01      7.2±0.02ms     5.6 MB/sec    1.00      7.2±0.01ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1611.3±5.78µs    10.3 MB/sec    1.00   1607.5±1.05µs    10.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    176.4±0.42µs    16.7 MB/sec    1.01    178.2±0.66µs    16.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.4±0.01ms     7.6 MB/sec    1.00      3.4±0.00ms     7.6 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.03     20.8±1.01ms  1998.7 KB/sec    1.00     20.2±0.77ms     2.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.2±0.37ms     3.2 MB/sec    1.02      5.3±0.20ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.00   630.1±29.16µs     4.7 MB/sec    1.06   667.2±22.24µs     4.4 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.2±0.37ms     3.1 MB/sec    1.07      8.8±0.46ms     2.9 MB/sec
linter/default-rules/large/dataset.py      1.01     10.3±0.49ms     3.9 MB/sec    1.00     10.2±0.38ms     4.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.3±0.20ms     7.3 MB/sec    1.01      2.3±0.22ms     7.2 MB/sec
linter/default-rules/numpy/globals.py      1.00    266.8±9.23µs    11.1 MB/sec    1.01   269.8±15.90µs    10.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.6±0.18ms     5.5 MB/sec    1.06      4.9±0.16ms     5.2 MB/sec

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We may need to do another pass in the future. I'm in process of reviewing each rule name and identify rules that can be merged (e.g. should LoadBeforeGlobalDeclaration be merged with undeclared-variable?

@charliermarsh charliermarsh merged commit 242dd3d into main Mar 22, 2023
@charliermarsh charliermarsh deleted the charlie/remove-use branch March 22, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename rules according to naming convention
2 participants