Make lint_only aware of the source kind

[dhruvmanila]

Summary

Make lint_only aware of the source kind

fixes: #5875

[dhruvmanila]

Current dependencies on/for this PR:

• main
  • PR Make lint_only aware of the source kind #5876 👈
    • PR Use Jupyter mode while parsing Notebook files #5552

This comment was auto-generated by Graphite.

[dhruvmanila]

> cargo run --bin ruff -- check --select=I001 --no-cache --isolated crates/ruff/resources/test/fixtures/jupyter/isort.ipynb --show-source
crates/ruff/resources/test/fixtures/jupyter/isort.ipynb:cell 1:1:1: I001 [*] Import block is un-sorted or un-formatted
  |
1 | / from pathlib import Path
2 | | import random
3 | | import math
4 | | from typing import Any
  | |_^ I001
5 |   import collections
6 |   # Newline should be added here
  |
  = help: Organize imports

crates/ruff/resources/test/fixtures/jupyter/isort.ipynb:cell 2:1:1: I001 [*] Import block is un-sorted or un-formatted
  |
1 | / from typing import Any
2 | | import collections
3 | | # Newline should be added here
  | |_^ I001
4 |   def foo():
5 |       pass
  |
  = help: Organize imports

Found 2 errors.
[*] 2 potentially fixable with the --fix option.

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      9.9±0.02ms     4.1 MB/sec    1.00      9.9±0.03ms     4.1 MB/sec
formatter/numpy/ctypeslib.py               1.00   1902.7±5.41µs     8.8 MB/sec    1.00   1894.8±8.93µs     8.8 MB/sec
formatter/numpy/globals.py                 1.00    208.2±7.59µs    14.2 MB/sec    1.00    207.8±0.25µs    14.2 MB/sec
formatter/pydantic/types.py                1.00      4.2±0.01ms     6.1 MB/sec    1.00      4.2±0.01ms     6.1 MB/sec
linter/all-rules/large/dataset.py          1.00     13.6±0.03ms     3.0 MB/sec    1.00     13.6±0.04ms     3.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.00ms     4.9 MB/sec    1.00      3.4±0.00ms     4.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    373.5±1.27µs     7.9 MB/sec    1.00    374.5±0.91µs     7.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.1±0.03ms     4.2 MB/sec    1.00      6.1±0.01ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.00      7.1±0.01ms     5.7 MB/sec    1.00      7.1±0.01ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1440.9±5.17µs    11.6 MB/sec    1.00   1442.1±4.17µs    11.5 MB/sec
linter/default-rules/numpy/globals.py      1.00    150.5±1.07µs    19.6 MB/sec    1.00    149.8±0.23µs    19.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.2±0.01ms     8.1 MB/sec    1.00      3.1±0.00ms     8.1 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     11.0±0.14ms     3.7 MB/sec    1.02     11.1±0.22ms     3.7 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.2±0.05ms     7.7 MB/sec    1.01      2.2±0.06ms     7.7 MB/sec
formatter/numpy/globals.py                 1.00    243.0±4.67µs    12.1 MB/sec    1.03   250.3±12.74µs    11.8 MB/sec
formatter/pydantic/types.py                1.00      4.7±0.11ms     5.4 MB/sec    1.01      4.8±0.13ms     5.3 MB/sec
linter/all-rules/large/dataset.py          1.00     15.4±0.18ms     2.6 MB/sec    1.01     15.5±0.29ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.09ms     4.1 MB/sec    1.00      4.1±0.10ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   485.3±11.20µs     6.1 MB/sec    1.01    489.8±9.12µs     6.0 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.9±0.10ms     3.7 MB/sec    1.02      7.0±0.17ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.0±0.10ms     5.1 MB/sec    1.01      8.1±0.11ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1689.3±50.96µs     9.9 MB/sec    1.00  1681.3±23.95µs     9.9 MB/sec
linter/default-rules/numpy/globals.py      1.00    191.4±6.97µs    15.4 MB/sec    1.00    191.1±4.37µs    15.4 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.05ms     7.1 MB/sec    1.01      3.6±0.05ms     7.0 MB/sec

[charliermarsh]

Should this not be optional? Seems like maybe it should be required everywhere 🤔

[dhruvmanila]

Yes, it should be. It probably needs to be defined at a top level and I've a local branch where I worked on that a bit. I'll be looking into it soon.