-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update F841
autofix to not remove line magic expr
#6117
Merged
charliermarsh
merged 1 commit into
dhruv/jupyter-cell-magic
from
dhruv/F841-line-magic-expr
Jul 27, 2023
Merged
Update F841
autofix to not remove line magic expr
#6117
charliermarsh
merged 1 commit into
dhruv/jupyter-cell-magic
from
dhruv/F841-line-magic-expr
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+0, -4, 0 error(s)) typeshed (+0, -4)
- stubs/Pillow/PIL/_imaging.pyi:12:7: PYI046 Private protocol `_PixelAccessor` is never used - stubs/bleach/bleach/callbacks.pyi:9:7: PYI046 Private protocol `_Callback` is never used - stubs/openpyxl/openpyxl/xml/_functions_overloads.pyi:26:7: PYI046 Private protocol `_HasTagAndText` is never used - stubs/openpyxl/openpyxl/xml/_functions_overloads.pyi:28:7: PYI046 Private protocol `_HasTagAndTextAndAttrib` is never used
BenchmarkLinux
Windows
|
MichaReiser
approved these changes
Jul 27, 2023
konstin
approved these changes
Jul 27, 2023
@@ -562,6 +562,18 @@ print("after empty cells") | |||
Ok(()) | |||
} | |||
|
|||
#[test] | |||
fn test_unused_variable() -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When these tests get more we can at some point move them into #[test_case]
charliermarsh
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
F841
autofix to not remove line magic exprTest Plan
Added test case for assignment statement with and without type annotation
fixes: #6116