Add support for simple generic type variables to UP040 #6314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
rule/type-alias-generic
branch
from
1834445 to
382e0f1
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
We don't remove unused variables in the module scope, since they could be imported from other modules (i.e., they are part of the module's public API). (We only remove unused variables within function scopes.) |
Ah that makes sense. We're pretty unlikely to ever remove these then. I don't think we should either, I've definitely imported them :D |
MichaReiser
reviewed
Aug 3, 2023
charliermarsh
approved these changes
Aug 4, 2023
zanieb
force-pushed
the
rule/type-alias-generic
branch
from
2fffafb to
bae9097
Compare
| fn visit_expr(&mut self, expr: &'a Expr) { | ||
| match expr { | ||
| Expr::Name(name) if name.ctx.is_load() => { | ||
| let Some(Stmt::Assign(StmtAssign { value, .. })) = |
There was a problem hiding this comment.
Does this need to match AnnAssign too? No, right?
There was a problem hiding this comment.
I don't think so. At least, Pyright complains about
from typing import TypeVar
T: TypeVar = TypeVar("T")
durumu
pushed a commit
to durumu/ruff
that referenced
this pull request
Aug 12, 2023
Extends astral-sh#6289 to support moving type variable usage in type aliases to use PEP-695. Does not remove the possibly unused type variable declaration. Presumably this is handled by other rules, but is not working for me. Does not handle type variables with bounds or variance declarations yet. Part of astral-sh#4617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #6289 to support moving type variable usage in type aliases to use PEP-695.
Does not remove the possibly unused type variable declaration.
Presumably this is handled by other rules, but is not working for me.We cannot remove module level declarations safely.Does not handle type variables with bounds or variance declarations yet.
Part of #4617