Formatter: Add SourceType to context to enable special formatting for stub files #6331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
MichaReiser
approved these changes
Aug 4, 2023
Comment on lines
6
to
29
| #[derive(Clone, Debug)] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub enum SourceType { | ||
| /// A `.py` file | ||
| Py, | ||
| /// A `.pyi` file | ||
| Pyi, | ||
| } | ||
|
|
||
| impl SourceType { | ||
| pub fn from_path(path: &Path) -> Option<Self> { | ||
| match path.extension().and_then(OsStr::to_str) { | ||
| Some("py") => Some(Self::Py), | ||
| Some("pyi") => Some(Self::Pyi), | ||
| _ => None, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Default for SourceType { | ||
| fn default() -> Self { | ||
| Self::Py | ||
| } | ||
| } |
There was a problem hiding this comment.
#5552 introduces a new PySourceType. What do you think of moving PySourceType to ruff_python_ast and re-using it here?
There was a problem hiding this comment.
-.- i was searching for this and couldn't find it, thanks
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
|
@dhruvmanila I've copied most of |
Co-authored-by: Micha Reiser <micha@reiser.io>
konstin
force-pushed
the
add-source-type-option
branch
from
c27ba8d to
fcc465c
Compare
konstin
changed the title
Hey, thanks for informing. I'll rebase it, no problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary This adds the information whether we're in a .py python source file or in a .pyi stub file to enable people working on #5822 and related issues.
I'm not completely happy with
Defaultfor something that depends on the input.Test Plan None, this is currently unused, i'm leaving this to first implementation of stub file specific formatting.