-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DerefMut for WithNodeLevel #6443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
PR Check ResultsBenchmarkLinux
Windows
|
Merged
konstin
added
internal
An internal refactor or improvement
formatter
Related to the formatter
labels
Aug 10, 2023
MichaReiser
approved these changes
Aug 10, 2023
Do you want to remove the other two methods? |
konstin
force-pushed
the
impl_deref_mut_for_WithNodeLevel
branch
from
August 10, 2023 16:32
9da5459
to
23af0a6
Compare
This way `WithNodeLevel` behaves like `PyFormatter`.
konstin
force-pushed
the
impl_deref_mut_for_WithNodeLevel
branch
from
August 11, 2023 10:32
23af0a6
to
39611cc
Compare
durumu
pushed a commit
to durumu/ruff
that referenced
this pull request
Aug 12, 2023
**Summary** Implement `DerefMut` for `WithNodeLevel` so it can be used in the same way as `PyFormatter`. I want this for my WIP upstack branch to enable `.fmt(f)` on `WithNodeLevel` context. We could extend this to remove the other two method from `WithNodeLevel`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Implement
DerefMut
forWithNodeLevel
so it can be used in the same way asPyFormatter
. I want this for my WIP upstack branch to enable.fmt(f)
onWithNodeLevel
context. We could extend this to remove the other two method fromWithNodeLevel
.