[`flake8-pytest-style`] Autofix `PT014` #6698

harupy · 2023-08-20T03:47:25Z

Summary

Test Plan

github-actions · 2023-08-20T03:59:24Z

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+14, -13, 0 error(s))

airflow (+11, -11)

- tests/always/test_secrets_local_filesystem.py:103:13: PT014 Duplicate of test case at index 2 in `@pytest_mark.parametrize`
+ tests/always/test_secrets_local_filesystem.py:103:13: PT014 [*] Duplicate of test case at index 2 in `@pytest_mark.parametrize`
- tests/operators/test_bash.py:181:13: PT014 Duplicate of test case at index 2 in `@pytest_mark.parametrize`
+ tests/operators/test_bash.py:181:13: PT014 [*] Duplicate of test case at index 2 in `@pytest_mark.parametrize`
- tests/providers/cncf/kubernetes/operators/test_pod.py:1214:13: PT014 Duplicate of test case at index 2 in `@pytest_mark.parametrize`
+ tests/providers/cncf/kubernetes/operators/test_pod.py:1214:13: PT014 [*] Duplicate of test case at index 2 in `@pytest_mark.parametrize`
- tests/providers/databricks/operators/test_databricks_sql.py:232:9: PT014 Duplicate of test case at index 5 in `@pytest_mark.parametrize`
+ tests/providers/databricks/operators/test_databricks_sql.py:232:9: PT014 [*] Duplicate of test case at index 5 in `@pytest_mark.parametrize`
- tests/providers/docker/operators/test_docker.py:533:13: PT014 Duplicate of test case at index 2 in `@pytest_mark.parametrize`
+ tests/providers/docker/operators/test_docker.py:533:13: PT014 [*] Duplicate of test case at index 2 in `@pytest_mark.parametrize`
- tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:488:13: PT014 Duplicate of test case at index 0 in `@pytest_mark.parametrize`
+ tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:488:13: PT014 [*] Duplicate of test case at index 0 in `@pytest_mark.parametrize`
- tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:489:13: PT014 Duplicate of test case at index 1 in `@pytest_mark.parametrize`
+ tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:489:13: PT014 [*] Duplicate of test case at index 1 in `@pytest_mark.parametrize`
- tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:493:13: PT014 Duplicate of test case at index 2 in `@pytest_mark.parametrize`
+ tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:493:13: PT014 [*] Duplicate of test case at index 2 in `@pytest_mark.parametrize`
- tests/providers/presto/hooks/test_presto.py:197:13: PT014 Duplicate of test case at index 2 in `@pytest_mark.parametrize`
+ tests/providers/presto/hooks/test_presto.py:197:13: PT014 [*] Duplicate of test case at index 2 in `@pytest_mark.parametrize`
- tests/providers/trino/hooks/test_trino.py:216:13: PT014 Duplicate of test case at index 2 in `@pytest_mark.parametrize`
+ tests/providers/trino/hooks/test_trino.py:216:13: PT014 [*] Duplicate of test case at index 2 in `@pytest_mark.parametrize`
- tests/www/views/test_views.py:534:9: PT014 Duplicate of test case at index 4 in `@pytest_mark.parametrize`
+ tests/www/views/test_views.py:534:9: PT014 [*] Duplicate of test case at index 4 in `@pytest_mark.parametrize`

securedrop (+1, -1)

- molecule/testinfra/common/test_fpf_apt_repo.py:64:9: PT014 Duplicate of test case at index 1 in `@pytest_mark.parametrize`
+ molecule/testinfra/common/test_fpf_apt_repo.py:64:9: PT014 [*] Duplicate of test case at index 1 in `@pytest_mark.parametrize`

scikit-build (+1, -1)

- tests/test_setup.py:545:9: PT014 Duplicate of test case at index 3 in `@pytest_mark.parametrize`
+ tests/test_setup.py:545:9: PT014 [*] Duplicate of test case at index 3 in `@pytest_mark.parametrize`

sphinx (+1, -0)

+    = help: Remove duplicate test case

Rules changed: 1

Rule	Changes	Additions	Removals
PT014	26	13	13

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      3.2±0.03ms    12.6 MB/sec    1.01      3.3±0.02ms    12.5 MB/sec
formatter/numpy/ctypeslib.py               1.00   668.4±15.48µs    24.9 MB/sec    1.01   676.1±16.63µs    24.6 MB/sec
formatter/numpy/globals.py                 1.00     69.2±0.37µs    42.6 MB/sec    1.01     70.2±0.32µs    42.0 MB/sec
formatter/pydantic/types.py                1.00  1316.9±28.50µs    19.4 MB/sec    1.01  1325.1±29.29µs    19.2 MB/sec
linter/all-rules/large/dataset.py          1.00     10.5±0.07ms     3.9 MB/sec    1.00     10.4±0.06ms     3.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.9±0.01ms     5.8 MB/sec    1.00      2.9±0.02ms     5.8 MB/sec
linter/all-rules/numpy/globals.py          1.00    319.5±1.68µs     9.2 MB/sec    1.00    319.6±1.24µs     9.2 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.4±0.04ms     4.7 MB/sec    1.00      5.4±0.03ms     4.7 MB/sec
linter/default-rules/large/dataset.py      1.01      5.6±0.02ms     7.3 MB/sec    1.00      5.6±0.01ms     7.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1185.5±2.64µs    14.0 MB/sec    1.00   1182.7±3.18µs    14.1 MB/sec
linter/default-rules/numpy/globals.py      1.00    122.9±0.21µs    24.0 MB/sec    1.01    123.6±1.15µs    23.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.5±0.01ms    10.1 MB/sec    1.01      2.5±0.03ms    10.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      3.7±0.05ms    10.9 MB/sec    1.01      3.8±0.06ms    10.8 MB/sec
formatter/numpy/ctypeslib.py               1.00   763.9±17.69µs    21.8 MB/sec    1.01   769.0±13.43µs    21.7 MB/sec
formatter/numpy/globals.py                 1.00     78.4±1.14µs    37.6 MB/sec    1.02     79.9±1.79µs    36.9 MB/sec
formatter/pydantic/types.py                1.00  1531.7±22.02µs    16.7 MB/sec    1.02  1557.2±40.76µs    16.4 MB/sec
linter/all-rules/large/dataset.py          1.00     12.6±0.12ms     3.2 MB/sec    1.00     12.6±0.14ms     3.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.09ms     4.8 MB/sec    1.00      3.5±0.03ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.00    437.1±8.46µs     6.8 MB/sec    1.00    436.1±5.44µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.6±0.07ms     3.9 MB/sec    1.00      6.6±0.08ms     3.9 MB/sec
linter/default-rules/large/dataset.py      1.00      7.1±0.07ms     5.8 MB/sec    1.00      7.1±0.07ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1486.3±16.48µs    11.2 MB/sec    1.01  1498.3±15.39µs    11.1 MB/sec
linter/default-rules/numpy/globals.py      1.00    172.8±3.42µs    17.1 MB/sec    1.01    174.5±2.74µs    16.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.1±0.04ms     8.1 MB/sec    1.01      3.2±0.04ms     8.1 MB/sec

charliermarsh · 2023-08-20T14:19:08Z

crates/ruff/src/rules/flake8_pytest_style/rules/parametrize.rs


    let mut seen: FxHashMap<ComparableExpr, usize> =
        FxHashMap::with_capacity_and_hasher(elts.len(), BuildHasherDefault::default());
+    let mut prev = &elts[0];


I think this should either be optional or we should insert it into seen outside of the loop and skip the first element.

charliermarsh · 2023-08-20T14:19:55Z

crates/ruff/src/rules/flake8_pytest_style/rules/parametrize.rs

@@ -558,19 +564,31 @@ fn check_duplicates(checker: &mut Checker, values: &Expr) {
    else {
        return;
    };
+    if elts.len() < 2 {


In general I'd probably prefer something like let [mut prev, ..] = elts else { return; };.

It better couples the condition to the access, whereas here, we have the condition up here, then the potentially-unsafe elts[0] below.

charliermarsh · 2023-08-20T15:03:02Z

crates/ruff/src/rules/flake8_pytest_style/rules/parametrize.rs

+                if checker.patch(diagnostic.kind.rule()) {
+                    let del_range = TextRange::new(prev.end(), elt.end());
+                    if !checker.indexer().comment_ranges().intersects(del_range) {
+                        diagnostic.set_fix(Fix::automatic(Edit::range_deletion(del_range)));


I think this won't quite do the right thing if one of the expressions is parenthesized (the range won't include the parentheses). We need to do something similar to remove_argument.

Autofix PT014

7ea6180

harupy changed the title ~~Autofix PT014~~ [[flake8-pytest-style]] Autofix PT014 Aug 20, 2023

harupy changed the title ~~[[flake8-pytest-style]] Autofix PT014~~ [flake8-pytest-style] Autofix PT014 Aug 20, 2023

charliermarsh reviewed Aug 20, 2023

View reviewed changes

harupy added 4 commits August 21, 2023 00:15

Address comments

a16cdad

Test case for parentheses

0e11ed2

Add tests

d2e8e77

Handle parentheses

fd74b22

charliermarsh self-requested a review August 20, 2023 17:29

charliermarsh added 2 commits August 20, 2023 23:09

Merge branch 'main' into autofix-PT014

695bf90

Rename

66eebf3

charliermarsh added the fixes Related to suggested fixes for violations label Aug 21, 2023

charliermarsh enabled auto-merge (squash) August 21, 2023 03:35

charliermarsh merged commit 086e110 into astral-sh:main Aug 21, 2023

harupy deleted the autofix-PT014 branch August 21, 2023 03:45

chenrui333 mentioned this pull request Aug 26, 2023

ruff 0.0.286 Homebrew/homebrew-core#140518

Merged

renovate bot mentioned this pull request Aug 31, 2023

⬆️ deps: Update dependency pyright to v1.1.356 cattidea/paddlepaddle-stubs#59

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[`flake8-pytest-style`] Autofix `PT014` #6698

[`flake8-pytest-style`] Autofix `PT014` #6698

harupy commented Aug 20, 2023

github-actions bot commented Aug 20, 2023 •

edited

Loading

charliermarsh Aug 20, 2023

charliermarsh Aug 20, 2023

charliermarsh Aug 20, 2023

charliermarsh Aug 20, 2023

[flake8-pytest-style] Autofix PT014 #6698

[flake8-pytest-style] Autofix PT014 #6698

Conversation

harupy commented Aug 20, 2023

Summary

Test Plan

github-actions bot commented Aug 20, 2023 • edited Loading

PR Check Results

Ecosystem

Benchmark

Linux

Windows

charliermarsh Aug 20, 2023

Choose a reason for hiding this comment

charliermarsh Aug 20, 2023

Choose a reason for hiding this comment

charliermarsh Aug 20, 2023

Choose a reason for hiding this comment

charliermarsh Aug 20, 2023

Choose a reason for hiding this comment

[`flake8-pytest-style`] Autofix `PT014` #6698

[`flake8-pytest-style`] Autofix `PT014` #6698

github-actions bot commented Aug 20, 2023 •

edited

Loading