Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hidden
--preview
/--no-preview
options toruff check
#7009Add hidden
--preview
/--no-preview
options toruff check
#7009Changes from all commits
0e44707
a16e3f5
fecfcac
475769d
29be01a
432f09b
05810f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So.. I think we could make this
Option<PreviewMode>
too but I'm not entirely sure how to make that play nicely with theJsonSchema
. I'm also not sure if we wantpreview = enabled | disabled
orpreview = true | false
for users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly looked into this but don't see a good solution for it other than implementing
Serialize
,Deserialize
andJsonSchema
manually onPreviewMode
if we wantpreview = true | false
(preview = enabled | disabled) should work out of the box.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm happy to leave it as-is then
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.