Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIM110 with a yield in the condition #7801

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

JelleZijlstra
Copy link
Contributor

And allow "await" in the loop iterable.

Fixes #7800

And allow "await" in the loop iterable.

Fixes astral-sh#7800
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 4, 2023

CodSpeed Performance Report

Merging #7801 will degrade performances by 2.37%

Comparing JelleZijlstra:sim110 (e27ec42) with main (7b4fb4f)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main JelleZijlstra:sim110 Change
linter/all-rules[pydantic/types.py] 72.5 ms 74.3 ms -2.37%
linter/default-rules[pydantic/types.py] 38.9 ms 38 ms +2.48%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@charliermarsh charliermarsh merged commit 600471e into astral-sh:main Oct 4, 2023
15 of 16 checks passed
@charliermarsh charliermarsh added the bug Something isn't working label Oct 4, 2023
@JelleZijlstra JelleZijlstra deleted the sim110 branch October 4, 2023 15:34
@JelleZijlstra JelleZijlstra restored the sim110 branch September 10, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIM110 with a yield in the condition
2 participants