Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider nursery rules to be in-preview for ruff rule #7812

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

charliermarsh
Copy link
Member

Summary

We treat these rules as preview elsewhere, so adding preview: false to the JSON and such seems like an error.

Closes #7804.

@charliermarsh charliermarsh changed the title Consider nursery rules to be in-preview for ruff rule Consider nursery rules to be in-preview for ruff rule Oct 4, 2023
@charliermarsh charliermarsh requested a review from zanieb October 4, 2023 13:46
@charliermarsh charliermarsh added the bug Something isn't working label Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh merged commit a0c846f into main Oct 4, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/explain branch October 4, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ruff rule shows PLR6301 as non-preview
2 participants