Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make serde a default feature of ruff_python_formatter #7825

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Make serde a default feature of ruff_python_formatter #7825

merged 1 commit into from
Oct 8, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Oct 5, 2023

This makes cargo test -p ruff_python_formatter actually run the tests again

@konstin
Make serde a default feature of ruff_python_formatter
c632870 
This makes `cargo test -p ruff_python_formatter` actually run the tests again
@konstin
Copy link
Member Author

konstin commented Oct 5, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@konstin konstin mentioned this pull request Oct 5, 2023
Merged
charliermarsh
charliermarsh approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I've now been running cargo test --features serde.)

@konstin konstin added the internal An internal refactor or improvement label Oct 6, 2023
@konstin konstin marked this pull request as ready for review October 6, 2023 08:56
@charliermarsh charliermarsh merged commit dd36a25 into main Oct 8, 2023
16 checks passed
@charliermarsh charliermarsh deleted the ruff_python_formatter-serde branch October 8, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstin @charliermarsh