Format comment before parameter default correctly #7870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Handle comment before the default values of function parameters correctly by inserting a line break instead of space after the equals sign where required.
```python
def f(
a = # parameter trailing comment; needs line break (1)
1,
b =
# default leading comment; needs line break (2)
2,
c = ( # the default leading can only be end-of-line with parentheses; no line break
3
),
d = (
# own line leading comment with parentheses; no line break
4
)
)
```
Fixes #7603
**Test Plan** Added the different cases and one more complex case as fixtures.
konstin
commented
Oct 9, 2023
Comment on lines
+63
to
+64
| (!needs_line_break).then_some(space), | ||
| needs_line_break.then_some(hard_line_break()), |
There was a problem hiding this comment.
This was meant as an if-then-else, not sure if it's better to split the write! into parts
charliermarsh
approved these changes
Oct 12, 2023
Comment on lines
+63
to
+64
| (!needs_line_break).then_some(space), | ||
| needs_line_break.then_some(hard_line_break()), |
charliermarsh
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Handle comment before the default values of function parameters correctly by inserting a line break instead of space after the equals sign where required.
Fixes #7603
Test Plan Added the different cases and one more complex case as fixtures.