Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autofix for PLR1714 #7910

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

diceroll123
Copy link
Contributor

Summary

Add autofix for PLR1714 using tuples.

If added complexity is desired, we can lean into the set part by doing some kind of builtin check on all of the comparator elements for starters, since we otherwise don't know if something's hashable.

Test Plan

cargo test, and manually.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+5, -5, 0 error(s))

airflow (+1, -1)

- [*] 16031 fixable with the `--fix` option (6314 hidden fixes can be enabled with the `--unsafe-fixes` option).
+ [*] 16031 fixable with the `--fix` option (6330 hidden fixes can be enabled with the `--unsafe-fixes` option).

aws-sam-cli (+1, -1)

- [*] 756 fixable with the `--fix` option (121 hidden fixes can be enabled with the `--unsafe-fixes` option).
+ [*] 756 fixable with the `--fix` option (122 hidden fixes can be enabled with the `--unsafe-fixes` option).

bokeh (+1, -1)

- [*] 17800 fixable with the `--fix` option (4721 hidden fixes can be enabled with the `--unsafe-fixes` option).
+ [*] 17800 fixable with the `--fix` option (4727 hidden fixes can be enabled with the `--unsafe-fixes` option).

securedrop (+1, -1)

- [*] 48 fixable with the `--fix` option (1 hidden fix can be enabled with the `--unsafe-fixes` option).
+ [*] 48 fixable with the `--fix` option (3 hidden fixes can be enabled with the `--unsafe-fixes` option).

pymilvus (+1, -1)

- [*] 233 fixable with the `--fix` option (129 hidden fixes can be enabled with the `--unsafe-fixes` option).
+ [*] 233 fixable with the `--fix` option (132 hidden fixes can be enabled with the `--unsafe-fixes` option).

@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Oct 11, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) October 11, 2023 14:30
@charliermarsh charliermarsh merged commit 1835d7b into astral-sh:main Oct 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants