Move ParenthesizedExpr to ruff_python_parser
#8987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
MichaReiser
commented
Dec 4, 2023
| impl ParenthesizedExpr { | ||
| /// Returns `true` if the expression is parenthesized. | ||
| pub(super) fn is_parenthesized(&self) -> bool { | ||
| self.range.start() != self.expr.range().start() |
There was a problem hiding this comment.
I changed the condition here to only test the start as this should be sufficient
charliermarsh
approved these changes
Dec 4, 2023
MichaReiser
force-pushed
the
move-parenthesized-expression
branch
from
9cd3834 to
2084d5a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ParenthesizedExpris some parser internal hack to makeWithItemparsing possible.ParenthesizedExprisn't part of our public AST.That's why this PR moves
ParenthesizedExprinto theruff_python_parsercrate withpub(super)visibility.Test Plan
cargo test