Parenthesize long type annotations in annotated assignments #9210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
formatter
MichaReiser
changed the base branch from
main
to
fix-avoid-parenthesizing-attribute-chains
|
Base automatically changed from
fix-avoid-parenthesizing-attribute-chains
to
main
December 20, 2023 23:42
MichaReiser
force-pushed
the
parenthesize-long-type-annotations-in-annotated-assigns
branch
2 times, most recently
from
95130ad
to
d3ce8c9
Compare
MichaReiser
commented
Dec 21, 2023
| class Test: | ||
| - safe_age: Decimal # the user's age, used to determine if it's safe for them to use ruff | ||
| + safe_age: ( | ||
| + Decimal # the user's age, used to determine if it's safe for them to use ruff |
There was a problem hiding this comment.
I'm not a huge fan of this change but it is consistent to how we would format the same assignment when Decimalis the assigned value
Input
safe_age = Decimal # the user's age....
MichaReiser
force-pushed
the
parenthesize-long-type-annotations-in-annotated-assigns
branch
2 times, most recently
from
29a97ed
to
9ddc579
Compare
MichaReiser
force-pushed
the
parenthesize-long-type-annotations-in-annotated-assigns
branch
from
9ddc579
to
8e14838
Compare
charliermarsh
approved these changes
Dec 22, 2023
Yeah, there are more changes if you include the function parameters. It's not a ton but a couple of 100 changed lines. |
MichaReiser
deleted the
parenthesize-long-type-annotations-in-annotated-assigns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements #8894 for annotated assignments. It intentionally excludes annotations in function definition because we're internally discussing whether we support the changes or not.
Test Plan
Ran the ecosystem check and there are.... no changes! Which is rather disappointing. I checked the diff shades output from the Black changes and verified that ruff formats the one shade the same as black.
I ran the similarity index script and verified that the numbers remain unchanged.