Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect attribute chains when resolving builtin call paths #9309

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Respect attribute chains when resolving builtin call paths #9309

merged 1 commit into from
Dec 29, 2023

Conversation

charliermarsh
Copy link
Member

Summary

When resolving dict.__dict__, we were discarding the .__dict__ segment when computing the call path.

Test Plan

cargo test

@charliermarsh charliermarsh added the bug Something isn't working label Dec 29, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) December 29, 2023 15:10
@charliermarsh charliermarsh merged commit 00f3c7d into main Dec 29, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/attr branch December 29, 2023 15:13
@charliermarsh charliermarsh mentioned this pull request Dec 29, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@miccal miccal mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliermarsh