Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow arbitrary configuration options to be overridden via the CLI #9599

Merged
merged 61 commits into from
Feb 9, 2024
Merged

Allow arbitrary configuration options to be overridden via the CLI #9599

merged 61 commits into from
Feb 9, 2024

Commits on Jan 21, 2024

  1. WIP

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    d73a453 View commit details
    Browse the repository at this point in the history

  2. Get it working with --isolated

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    159fada View commit details
    Browse the repository at this point in the history

  3. Get it working without --isolated

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    7cd900c View commit details
    Browse the repository at this point in the history

  4. i can spell

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    3cdbec7 View commit details
    Browse the repository at this point in the history

  5. Fix a couple build/test failures

    @AlexWaygood
    AlexWaygood committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    0f2cc2c View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Simplify Configuration.transform()

    @AlexWaygood
    AlexWaygood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    18daf07 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary special casing

    @AlexWaygood
    AlexWaygood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    721653d View commit details
    Browse the repository at this point in the history

  3. Just pass a Vec to from_cli_options

    @AlexWaygood
    AlexWaygood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7bb72f5 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Misc review comments

    @AlexWaygood
    AlexWaygood committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e7a1d89 View commit details
    Browse the repository at this point in the history

  2. More docs cleanup

    @AlexWaygood
    AlexWaygood committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7c05cd5 View commit details
    Browse the repository at this point in the history

  3. use an Arc

    @AlexWaygood
    AlexWaygood committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    26b7dc8 View commit details
    Browse the repository at this point in the history

  4. Use clap a little more for slightly prettier errors

    @AlexWaygood
    AlexWaygood committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    59e6e0a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Merge branch 'main' into arbitrary-cli-overrides

    @AlexWaygood
    AlexWaygood committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f33e91e View commit details
    Browse the repository at this point in the history

  2. regen docs

    @AlexWaygood
    AlexWaygood committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    cd6b4ce View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Improve error messages

    @AlexWaygood
    AlexWaygood committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3fb5d21 View commit details
    Browse the repository at this point in the history

  2. Improve error messages more

    @AlexWaygood
    AlexWaygood committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2568265 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into arbitrary-cli-overrides

    @AlexWaygood
    AlexWaygood committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d6a18fe View commit details
    Browse the repository at this point in the history

  4. Add tests for some failure cases

    @AlexWaygood
    AlexWaygood committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8379890 View commit details
    Browse the repository at this point in the history

  5. Also test the formatter

    @AlexWaygood
    AlexWaygood committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    366cd1b View commit details
    Browse the repository at this point in the history

  6. Many more tests

    @AlexWaygood
    AlexWaygood committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2583136 View commit details
    Browse the repository at this point in the history

  7. spelling

    @AlexWaygood
    AlexWaygood committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    981210c View commit details
    Browse the repository at this point in the history

  8. Simplify some code

    @AlexWaygood
    AlexWaygood committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3bfcae2 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Further improve error messages

    @AlexWaygood
    AlexWaygood committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e32dd0a View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @AlexWaygood
    AlexWaygood committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    aca4af5 View commit details
    Browse the repository at this point in the history

  3. couple more tests

    @AlexWaygood
    AlexWaygood committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    446517b View commit details
    Browse the repository at this point in the history

  4. Docs

    @AlexWaygood
    AlexWaygood committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c39fbd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Micha Reiser <micha@reiser.io>
    @AlexWaygood @MichaReiser
    AlexWaygood and MichaReiser authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ebd7286 View commit details
    Browse the repository at this point in the history

  2. add a newline 

    Co-authored-by: Micha Reiser <micha@reiser.io>
    @AlexWaygood @MichaReiser
    AlexWaygood and MichaReiser authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d771243 View commit details
    Browse the repository at this point in the history

  3. Fix compile; address more Micha comments

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    be48c4f View commit details
    Browse the repository at this point in the history

  4. Couple more comments

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    8f79c65 View commit details
    Browse the repository at this point in the history

  5. Return &Path from config_file()

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    1cc613c View commit details
    Browse the repository at this point in the history

  6. Improve docs for --config

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    c12bb11 View commit details
    Browse the repository at this point in the history

  7. regen docs

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a880691 View commit details
    Browse the repository at this point in the history

  8. Delete Configuration::transform()

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    59e07c3 View commit details
    Browse the repository at this point in the history

  9. Rename the enum and its variants

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    7ec9e8a View commit details
    Browse the repository at this point in the history

  10. More consistent naming for arguments that take instances of `ConfigAr… 

    …guments`
    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    de846ba View commit details
    Browse the repository at this point in the history

  11. Better dev docs for the ConfigArguments struct

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    893f214 View commit details
    Browse the repository at this point in the history

  12. Rework docs; improve test

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0ccc608 View commit details
    Browse the repository at this point in the history

  13. cargo fmt

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    b12a9c7 View commit details
    Browse the repository at this point in the history

  14. Don't return clap::Error after the initial argument-parsing phase

    @AlexWaygood
    AlexWaygood committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    1501eeb View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Various cleanups

    @AlexWaygood
    AlexWaygood committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e46c06a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into arbitrary-cli-overrides

    @AlexWaygood
    AlexWaygood committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e39aa39 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into arbitrary-cli-overrides

    @AlexWaygood
    AlexWaygood authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e1a3328 View commit details
    Browse the repository at this point in the history

  4. Fixup some issues after merging in main

    @AlexWaygood
    AlexWaygood committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d83cfa5 View commit details
    Browse the repository at this point in the history

  5. Fix remaining test failures

    @AlexWaygood
    AlexWaygood committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    138c6c3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into arbitrary-cli-overrides

    @AlexWaygood
    AlexWaygood authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e500b39 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge branch 'main' into arbitrary-cli-overrides

    @AlexWaygood
    AlexWaygood committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    acca909 View commit details
    Browse the repository at this point in the history

  2. Fixup after merge

    @AlexWaygood
    AlexWaygood committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5e83ef8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'arbitrary-cli-overrides' of https://github.com/AlexWayg… 

    …ood/ruff into arbitrary-cli-overrides
    @AlexWaygood
    AlexWaygood committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    18da11b View commit details
    Browse the repository at this point in the history

  4. `` 

    Co-authored-by: Zanie Blue <contact@zanie.dev>
    @AlexWaygood @zanieb
    AlexWaygood and zanieb authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    0b0917b View commit details
    Browse the repository at this point in the history

  5. Address some Zanie comments

    @AlexWaygood
    AlexWaygood committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5074bff View commit details
    Browse the repository at this point in the history

  6. Merge branch 'arbitrary-cli-overrides' of https://github.com/AlexWayg… 

    …ood/ruff into arbitrary-cli-overrides
    @AlexWaygood
    AlexWaygood committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c6019f7 View commit details
    Browse the repository at this point in the history

  7. Add a test for overriding a deprecated CLI option via the CLI

    @AlexWaygood
    AlexWaygood committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7d6f9dd View commit details
    Browse the repository at this point in the history

  8. regen docs

    @AlexWaygood
    AlexWaygood committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bb2e6ee View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Use insta-filters for the tests where the tempdir path is included … 

    …in the output
    @AlexWaygood
    AlexWaygood committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7739440 View commit details
    Browse the repository at this point in the history

  2. Multiline tips instead of multiple tips

    @AlexWaygood
    AlexWaygood committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    88e7273 View commit details
    Browse the repository at this point in the history

  3. Make more concise

    @AlexWaygood
    AlexWaygood committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    bccab4e View commit details
    Browse the repository at this point in the history

  4. Differentiate between TOML syntax errors and valid TOML that we don't… 

    … know what to do with
    @AlexWaygood
    AlexWaygood committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6eea797 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Address Charlie's docs review

    @AlexWaygood
    AlexWaygood committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    983e5aa View commit details
    Browse the repository at this point in the history

  2. Add a transitional sentence

    @AlexWaygood
    AlexWaygood committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    789d1d0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into arbitrary-cli-overrides

    @AlexWaygood
    AlexWaygood committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0f8a583 View commit details
    Browse the repository at this point in the history